Fix Cypress tests around sorted documents #2412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
scytacki
commented
Sep 22, 2024
•
scytacki
commented
- fix teacher share test:
- the teacher was added to a group (teachers aren't supposed to be in groups
- the sort group sections weren't loaded before being expanded
- fix student test, it was using demo space for testing which made it unpredictable
- enable sort filter persistence test, it was using demo space for testing which made it unpredictable
- added a new helper visitQaSubtabsUnit to improve readability
- the teacher was added to a group (teachers aren't supposed to be in groups - the sort group sections weren't loaded before being expanded
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2412 +/- ##
==========================================
- Coverage 86.28% 86.26% -0.03%
==========================================
Files 741 741
Lines 38206 38206
Branches 9768 9768
==========================================
- Hits 32966 32957 -9
- Misses 4939 4948 +9
Partials 301 301
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
collaborative-learning
|
||||||||||||||||||||||||||||
| Project |
collaborative-learning
|
| Branch Review |
188315060-fix-teacher-share-test
|
| Run status |
|
| Run duration | 01m 46s |
| Commit |
|
| Committer | Scott Cytacki |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
1
|
| View all changes introduced in this branch ↗︎ | |
- both tests were using a demo space for testing - also added a new helper visitQaSubtabsUnit to improve readability
scytacki
changed the title
emcelroy
approved these changes
Sep 23, 2024
|
|
||
| cy.log("verify user's own documents are not marked as private and are accessible in the compact view"); | ||
| // In this case the sections are still open from before | ||
| // openAllGroupSections(); |
There was a problem hiding this comment.
I'm pretty sure you meant to leave this here for extra clarity, but wanted to note the commented-out call to openAllGroupSections in case not.
There was a problem hiding this comment.
Yeah I left it there clarity. 👍
|
@johnTcrawford I'm going to merge this, but if you are working on sorted document tests it would still be good to take a look at these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.