Graph manual points editing

[bgoldowsky]

See PT-185581730

Adds the ability to create manual points, and edit all points on a graph.

Implementation notes:

• For dragging points, some existing existing code was updated. In CODAP, this allows dragging points but they revert to their original position afterwards. It was nonfunctional in CLUE because it was expecting graph dots to be simple <circle> elements; CLUE's are now <g> elements containing two circles for the main dot and the highlight. I updated that, as well as replacing case selection with cell selection as the basis for dragging selected points.
• Related code that allows selecting points by dragging a rectangle was also updated/fixed to respect cell selection and work with multi-layer graphs.
• Autoscaling is improved and slightly refactored so that (a) the graph will autoscale after you drag points around (if autoscaling is enabled and axes are not locked), and (b) it will wait until you are done dragging before attempting this.
• Some undo tweaks are included in this PR, but it does not attempt to fix undo/redo behavior in general for dragging. Specifically, many undo/history records are created for each drag 'event'.
• The qa-config-subtabs local unit is updated to include the new buttons, so that they can be tested there.

[codecov]

Codecov Report

Attention: Patch coverage is 84.38438% with 52 lines in your changes are missing coverage. Please review.

Project coverage is 83.49%. Comparing base (661c7c5) to head (9828047).

Files	Patch %	Lines
src/plugins/graph/components/background.tsx	67.03%	26 Missing and 4 partials ⚠️
src/plugins/graph/utilities/graph-utils.ts	50.00%	11 Missing and 2 partials ⚠️
src/plugins/graph/models/graph-model.ts	94.73%	3 Missing ⚠️
...ns/graph/components/graph-toolbar-registration.tsx	93.10%	2 Missing ⚠️
...c/plugins/graph/models/data-configuration-model.ts	66.66%	2 Missing ⚠️
...omponents/utilities/editable-label-with-button.tsx	92.30%	1 Missing ⚠️
src/plugins/graph/d3-types.ts	92.30%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2220      +/-   ##
==========================================
+ Coverage   83.42%   83.49%   +0.06%     
==========================================
  Files         688      689       +1     
  Lines       34075    34276     +201     
  Branches     8836     8888      +52     
==========================================
+ Hits        28428    28619     +191     
- Misses       5352     5357       +5     
- Partials      295      300       +5     

Flag	Coverage Δ
cypress	73.24% <86.14%> (+0.12%)	⬆️
cypress-regression	73.24% <86.14%> (+0.12%)	⬆️
cypress-smoke	29.97% <3.71%> (-0.14%)	⬇️
jest	51.80% <23.12%> (-0.14%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[cypress]

1 flaky test on run #11660 ↗︎

0

95

5

0

1

Details:

null
Project: collaborative-learning	Commit: 98280479ff
Status: Passed	Duration: 09:08 💡
Started: Mar 14, 2024 4:46 PM	Ended: Mar 14, 2024 4:55 PM

  cypress/e2e/functional/teacher_tests/teacher_curation_spec.js • 1 flaky test

View Output

Test		Artifacts
verify document curation > verify starring and unstar		Test Replay Screenshots

Review all test suite changes for PR #2220 ↗︎

[scytacki]

This looks good. I didn't look super close at all of the graph changes because I'm not that familiar with that code.

I did find one React component defined inside of another which can cause problems. But it seems to be working so you don't need to fix it right away.

[scytacki]

The story has passed QA, I'll update this PR and merge it.