Add support for .NET Framework 4.7.1 and .NET Standard 2.1 #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #127 +/- ##
=======================================
Coverage 99.16% 99.16%
=======================================
Files 13 13
Lines 1431 1436 +5
Branches 155 155
=======================================
+ Hits 1419 1424 +5
Misses 5 5
Partials 7 7 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue are you addressing?
Compatibility issues.
How have you addressed the issue?
Lots of
#ifpragmas have been used to modify the code to allow compatibility with C# 7.3, enabling us to build with .NET Framework 4.7.1 and .NET Standard 2.1 in mind. This greatly increases compatibility of the library.How have you tested your patch?
net471tests pass, butnetstandard2.1is untested. Not sure what to do here.