Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize #118 #123

Merged
merged 1 commit into from
Nov 25, 2023
Merged

Optimize #118 #123

merged 1 commit into from
Nov 25, 2023

Conversation

computablee
Copy link
Owner

Which issue are you addressing?

Optimizes the PR #118

How have you addressed the issue?

Instead of weird casting and Unsafe.As, we simply invert the bits, add 1, then atomically add. This is in-line with 2's compliment arithmetic.

How have you tested your patch?

This is the first PR whose changes have been formally verified with a proof assistant. Of course, the unit tests still pass :)

Copy link

codecov bot commented Nov 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (33a8e90) 99.22% compared to head (708a1ff) 99.22%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #123   +/-   ##
=======================================
  Coverage   99.22%   99.22%           
=======================================
  Files          12       12           
  Lines        1291     1291           
  Branches      137      137           
=======================================
  Hits         1281     1281           
  Misses          5        5           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@computablee computablee merged commit aa833ba into main Nov 25, 2023
17 checks passed
@computablee computablee deleted the performance branch November 26, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant