Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set charset for actual unicode support #551

Merged
merged 1 commit into from
Sep 3, 2023
Merged

Set charset for actual unicode support #551

merged 1 commit into from
Sep 3, 2023

Conversation

oliver-ni
Copy link
Contributor

@oliver-ni oliver-ni commented Sep 2, 2023

This PR fixes unicode support, allowing for (among other things) emoji to be used in event names.

Tested and ready to go.

@oliver-ni
Copy link
Contributor Author

Was mentioned here: #537 (comment)

Copy link
Contributor

@lo-maxwell lo-maxwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works fine locally 👌

@oliver-ni oliver-ni merged commit db090ca into master Sep 3, 2023
3 checks passed
@ochan1 ochan1 requested review from ochan1 and removed request for ochan1 September 3, 2023 23:03
@ochan1
Copy link
Contributor

ochan1 commented Sep 3, 2023

This looks good, I would have put it here but didn't know how to test or where to put it

Please make sure this works on Production, since sqlite3 dev mode already is fine with emojis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants