Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added helper functions for creating various Tcp packets #32

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

compscidr
Copy link
Owner

Adds a factory class for creating various Tcp packets:

  • ACK
  • FIN
  • RST
  • SYN
  • SYN-ACK

Also adds test coverage to ensure they all work.

Fixes: #30

@compscidr compscidr merged commit 506b383 into main Oct 16, 2024
1 check passed
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 96.82540% with 4 lines in your changes missing coverage. Please review.

Project coverage is 97.89%. Comparing base (ab3e8cf) to head (1a8fbb2).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
.../jasonernst/knet/transport/tcp/TcpHeaderFactory.kt 96.63% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #32      +/-   ##
============================================
- Coverage     97.97%   97.89%   -0.09%     
- Complexity      385      400      +15     
============================================
  Files            55       56       +1     
  Lines          1827     1947     +120     
  Branches        208      213       +5     
============================================
+ Hits           1790     1906     +116     
- Misses           30       32       +2     
- Partials          7        9       +2     
Flag Coverage Δ
unittests 97.89% <96.82%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement helper functions for creating various Tcp Headers
1 participant