Skip to content
This repository has been archived by the owner on Mar 27, 2019. It is now read-only.

ugly "outdated" logs #612

Open
stephenmathieson opened this issue Nov 24, 2014 · 4 comments
Open

ugly "outdated" logs #612

stephenmathieson opened this issue Nov 24, 2014 · 4 comments

Comments

@stephenmathieson
Copy link
Contributor

imo, this is horrible:

$ node_modules/.bin/component-build 

  outdated name of a dependency : please update: "component/search.js" -> "componentjs/search.js"
   installed : yields/[email protected] in 465ms
   installed : component/[email protected] in 570ms
   installed : component/[email protected] in 132ms

  [ ... ]

why not:

  warning: outdated dependency name; please update "component/search.js" -> "componentjs/search.js"

... or something?

@netpoetica
Copy link

I agree with this, but I think we might want to consider this as part of a more major log output overhaul, because I've seen a lot of logs like this.

@timaschew
Copy link
Member

have you some other examples?
what exactly is ugly? that there is a missing warning prefix? or the wording?

@netpoetica
Copy link

@timaschew I think for me it's some of the sentence particles using arbitrary punctuation, in combination with all-lowercase words. I don't think the logs are awful, they're just not super-polished.

For example, outdated name of a dependency : please update: is just strange use of the colon twice.

A clear structure like

LOG_LEVEL + TITLE + ":" + MESSAGE
Warning - Outdated Dependencies: Please update "component/search.js" to "componentjs/search.js"

// or

Warning: Outdated Dependencies
Please update "component/search.js" to "componentjs/search.js"

// or
Warning -> Outdated Dependencies: Please update "component/search.js" to "componentjs/search.js"

Would be good to hear from @stephenmathieson for detail about possible improvements.

@stephenmathieson
Copy link
Contributor Author

keep the left side of the : short and simple. for example: warning : ... (as suggested in the OP).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants