Update doc build instructions #342
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgvassilev
reviewed
Oct 28, 2024
|
@vgvassilev I ran 'rstfmt -w 80' on both files, so hopefully that fixes the width issue. Any other comments on the PR, or is it ok to merge now? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #342 +/- ##
=======================================
Coverage 74.43% 74.43%
=======================================
Files 8 8
Lines 3204 3204
=======================================
Hits 2385 2385
Misses 819 819 |
|
Looks good to me but do we have a CI to make sure our docs PRs work? If not we can steal the one we did in clad... |
|
I'll copy the ci from Clad which checks docs to CppInterOp tomorrow, then you can review the PR again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This the first in a series of PRs to update the documentation folder. This first PR will update the build instructions to match those in the readme.