Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client-admin module upgrade #1798

Open
wants to merge 1 commit into
base: edge
Choose a base branch
from

Conversation

thomassth
Copy link

@thomassth thomassth commented Jul 19, 2024

cleaned out most packages that had vulnerabilities.

Remaining 1 vuln from npm audit --prod is related to React Router v6, which is a more substantial upgrade; will do in a separate commit.

@ballPointPenguin
Copy link
Contributor

Using ~ instead of ^ for versions in package.json was an intentional choice to avoid breaking changes from JS package churn. To maintain stability, it's better to manually update package.json after testing new versions, than to allow npm to ^^^ bump versions unexpectedly.

@ballPointPenguin
Copy link
Contributor

For example @thomassth here's a much more cautious set of updates; #1824
(But maybe this doesn't solve the vulnerabilities?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants