Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable importance checkbox for admin and participant #1682

Open
wants to merge 6 commits into
base: edge
Choose a base branch
from

Conversation

ballPointPenguin
Copy link
Contributor

@ballPointPenguin ballPointPenguin commented May 12, 2023

@ballPointPenguin ballPointPenguin changed the title Implement Comment Prioritization Checkbox Enable priority checkbox for admin and participant May 12, 2023
@ballPointPenguin ballPointPenguin marked this pull request as ready for review May 12, 2023 21:52
@ballPointPenguin
Copy link
Contributor Author

TODO (future):

  • Clarify or remove star / stars / starred code and the stars table
  • Clarify or remove weight logic
  • Test this with Cypress

@xeeg xeeg added this to the Stable milestone May 22, 2023
fill: #8a8a8a;
"
data-text="{{s.importantCheckboxDesc}}"
onclick="alert(this.dataset.text)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace the alert with a tooltip here. on-hover for desktop and on-tap for mobile.

@@ -330,9 +330,23 @@
<div style="text-align: center; margin-bottom: 20px">
<label class="weight-label">
<span class="weight-radio"></span>
<input type="checkbox" name="checkbox" id="weight_high">
<input type="checkbox" name="checkbox" id="weight_high" aria-describedby="importantCheckboxDesc">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move the checkbox above the agree/disagree/pass buttons.

@xeeg xeeg assigned xeeg and ballPointPenguin and unassigned xeeg May 23, 2023
@ballPointPenguin ballPointPenguin added feature-request For new feature suggestions P2 labels Jun 13, 2023
@xeeg xeeg modified the milestones: Stable, Yuki Jun 13, 2023
@xeeg
Copy link
Contributor

xeeg commented Jul 10, 2023

@metasoarous could you please catch the "high_priority" field in the export function.

@metasoarous metasoarous changed the title Enable priority checkbox for admin and participant Enable importance checkbox for admin and participant Oct 27, 2023
@metasoarous
Copy link
Member

metasoarous commented Oct 27, 2023

@colinmegill Would you please do a design review on the relative positioning of the checkbox & buttons?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request For new feature suggestions P2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants