-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modular JAR: Add module-info module descriptor and require Java 9+ #286
Conversation
Nice!! Oh yeah!! |
Thank you very much!!! You're the real hero! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #286 +/- ##
============================================
- Coverage 94.81% 94.78% -0.04%
Complexity 252 252
============================================
Files 130 131 +1
Lines 4124 4119 -5
Branches 606 604 -2
============================================
- Hits 3910 3904 -6
- Misses 106 107 +1
Partials 108 108
|
This comment was marked as spam.
This comment was marked as spam.
We've waited long enough for the ecosystem and tools such as Android to catch up. Making it proper modular means people can run jlink on it. Fixes #125.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@noties could you have a look at these and other changes in the Android directory? The build is green with these changes, but I'm not sure I did everything properly.
There was one problem of using String#repeat
(introduced in Java 11), which is not yet available on the minimum API level, which the Android build detected. I changed the code not to use that for now, and now the build is green.
We've waited long enough for the ecosystem and tools such as Android to catch up. Making it proper modular means people can run jlink on it. Fixes #125.