Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: notebook for HKG alt message validation #33647

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

jyoung8607
Copy link
Collaborator

Jupyter notebook for validating some of the complex HKG alternate message selection logic. As written, it's meant to look at the gearshift message needed for CAN-FD EVs, but can easily be adapted for other messages (and brands).

Currently commaai/opendbc#1131 needs to add Yet Another Special Flag, but using this data, we should be able to simplify all HKG CAN-FD EVs to use the exact same message and code path.

Analyzing segment ff2bd20623fcaeaa/2023-11-26--16-27-04/5/s    for KIA EV6 2022
  GEAR_SHIFTER    gear=4.0
  ACCELERATOR     gear=5.0
Analyzing segment 3f1a6480f940cf9a/2024-01-10--23-06-11/16/s   for KIA EV6 2022
  GEAR_SHIFTER    gear=4.0
  ACCELERATOR     gear=5.0
Analyzing segment b0a9998109ed0053/2023-12-15--11-10-18/12/s   for KIA EV6 2022
  GEAR_SHIFTER    gear=4.0
  ACCELERATOR     gear=5.0
Analyzing segment 6e14aa2ed85025df/2023-11-15--13-18-12/24/s   for KIA EV6 2022
  GEAR_SHIFTER    gear=4.0
  ACCELERATOR     gear=5.0
Analyzing segment a43f21df3a1ca12d/2024-01-25--08-56-22/16/s   for KIA EV6 2022
  GEAR_SHIFTER    gear=4.0
  ACCELERATOR     gear=5.0
Analyzing segment 1618132d68afc876/2023-12-05--13-49-24/11/s   for HYUNDAI KONA ELECTRIC 2ND GEN
  GEAR_SHIFTER    gear=4.0
  ACCELERATOR     gear=5.0
Analyzing segment 1618132d68afc876/2023-11-26--12-31-18/17/s   for HYUNDAI KONA ELECTRIC 2ND GEN
  GEAR_SHIFTER    gear=4.0
  ACCELERATOR     gear=5.0
Analyzing segment 1618132d68afc876/2023-12-05--11-51-44/3/s    for HYUNDAI KONA ELECTRIC 2ND GEN
  GEAR_SHIFTER    gear=4.0
  ACCELERATOR     gear=5.0
Analyzing segment 1618132d68afc876/2023-08-27--09-32-14/13/s   for HYUNDAI KONA 2ND GEN
  GEAR_SHIFTER    gear=4.0
  ACCELERATOR     gear=5.0
Analyzing segment 1618132d68afc876/2024-01-25--15-07-04/24/s   for HYUNDAI KONA ELECTRIC 2ND GEN
  GEAR_SHIFTER    gear=4.0
  ACCELERATOR     gear=5.0
Analyzing segment 223780ed74116bc2/2023-11-16--09-44-56/15/s   for HYUNDAI IONIQ 5 2022
  GEAR_SHIFTER    gear=4.0
  ACCELERATOR     gear=5.0
Analyzing segment ba9951252624f37d/2024-01-20--22-33-23/118/s  for HYUNDAI IONIQ 5 2022
  GEAR_SHIFTER    gear=4.0
  ACCELERATOR     gear=5.0
Analyzing segment 8379b28e51ceb3b1/2023-11-09--23-21-58/92/s   for HYUNDAI IONIQ 5 2022
  GEAR_SHIFTER    gear=4.0
  ACCELERATOR     gear=5.0
Analyzing segment 26fac43e27cd6091/2023-11-06--12-23-21/9/s    for HYUNDAI IONIQ 5 2022
  GEAR_SHIFTER    gear=1.0
  ACCELERATOR     gear=0.0
Analyzing segment 5edb897a0ec7a477/2024-01-13--20-41-36/101/s  for HYUNDAI IONIQ 5 2022
  GEAR_SHIFTER    gear=4.0
  ACCELERATOR     gear=5.0
Analyzing segment 66cf8ea23b7c2789/2023-12-04--13-48-53/5/s    for KIA NIRO EV 2ND GEN
  GEAR_SHIFTER    gear=4.0
  ACCELERATOR     gear=5.0
Analyzing segment b153671049a867b3/2023-12-10--20-31-37/2/s    for KIA NIRO EV 2ND GEN
  GEAR_SHIFTER    gear=4.0
  ACCELERATOR     gear=5.0
Analyzing segment b153671049a867b3/2023-12-03--21-08-30/14/s   for KIA NIRO EV 2ND GEN
  GEAR_SHIFTER    gear=4.0
  ACCELERATOR     gear=5.0
Analyzing segment b153671049a867b3/2023-11-07--19-52-23/0/s    for KIA NIRO EV 2ND GEN
  GEAR_SHIFTER    gear=4.0
  ACCELERATOR     gear=5.0
Analyzing segment b153671049a867b3/2023-07-12--19-25-18/6/s    for KIA NIRO EV 2ND GEN
  GEAR_SHIFTER    gear=4.0
  ACCELERATOR     gear=5.0
Analyzing segment 9ea4578ee2b1abcb/2023-11-18--07-59-26/11/s   for HYUNDAI IONIQ 6 2023
  GEAR_SHIFTER    gear=4.0
  ACCELERATOR     gear=5.0
Analyzing segment 0ad7facc77922c3e/2023-12-21--17-47-25/18/s   for HYUNDAI IONIQ 6 2023
  GEAR_SHIFTER    gear=4.0
  ACCELERATOR     gear=5.0
Analyzing segment 26968f888e7330d3/2024-01-02--11-18-37/8/s    for HYUNDAI IONIQ 6 2023
  GEAR_SHIFTER    gear=4.0
  ACCELERATOR     gear=5.0
Analyzing segment 9ea4578ee2b1abcb/2023-11-27--21-03-24/33/s   for HYUNDAI IONIQ 6 2023
  GEAR_SHIFTER    gear=4.0
  ACCELERATOR     gear=5.0
Analyzing segment df7fdd56970d90fe/2024-01-07--01-04-39/26/s   for HYUNDAI IONIQ 6 2023
  GEAR_SHIFTER    gear=4.0
  ACCELERATOR     gear=5.0
Analyzing segment 94542b2d06f7a9a6/2023-12-11--14-45-44/0/s    for GENESIS GV60 ELECTRIC 1ST GEN
  GEAR_SHIFTER    gear=4.0
  ACCELERATOR     gear=5.0
Analyzing segment 94542b2d06f7a9a6/2023-12-11--20-57-09/8/s    for GENESIS GV60 ELECTRIC 1ST GEN
  GEAR_SHIFTER    gear=4.0
  ACCELERATOR     gear=5.0
Analyzing segment 94542b2d06f7a9a6/2024-01-03--12-52-38/5/s    for GENESIS GV60 ELECTRIC 1ST GEN
  GEAR_SHIFTER    gear=4.0
  ACCELERATOR     gear=5.0
Analyzing segment 94542b2d06f7a9a6/2024-01-19--19-57-52/47/s   for GENESIS GV60 ELECTRIC 1ST GEN
  GEAR_SHIFTER    gear=4.0
  ACCELERATOR     gear=5.0
Analyzing segment 94542b2d06f7a9a6/2024-01-03--13-01-23/1/s    for GENESIS GV60 ELECTRIC 1ST GEN
  GEAR_SHIFTER    gear=4.0
  ACCELERATOR     gear=5.0
Analysis finished

@github-actions github-actions bot added the tools label Sep 24, 2024
@jyoung8607 jyoung8607 merged commit 17b29f4 into commaai:master Sep 25, 2024
16 checks passed
@jyoung8607 jyoung8607 deleted the hkg-canfd-notebook branch September 25, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant