cars: remove some external imports #33133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshane
changed the title
|
|
||
| LongCtrlState = car.CarControl.Actuators.LongControlState | ||
| VisualAlert = car.CarControl.HUDControl.VisualAlert | ||
| V_CRUISE_MAX = 145 |
There was a problem hiding this comment.
why not put into some helper in selfdrive/car/? somehow specific to ford?
There was a problem hiding this comment.
I planned on getting rid of this one, feels like we can set it based on the actuators packet, waiting on Harald looking into this. Will add a TODO to look into this
Edison-CBS
pushed a commit
to Edison-CBS/openpilot
that referenced
this pull request
Sep 15, 2024
* ford and gm * clean that up * also this * honda * temp fix * move into selfdrive.car * clean up * more old-commit-hash: 0739d79
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start to remove ignores from #32973