selfdrive/car: ban imports from external modules #32973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:
|
deanlee
force-pushed
the
check_imports
branch
2 times, most recently
from
cfd45ff
to
5a0d2db
Compare
sshane
reviewed
Jul 15, 2024
|
thanks! |
sshane
added a commit
that referenced
this pull request
Jul 15, 2024
Edison-CBS
pushed a commit
to Edison-CBS/openpilot
that referenced
this pull request
Sep 15, 2024
* lint import * Update selfdrive/car/__init__.py --------- Co-authored-by: Shane Smiskol <[email protected]> old-commit-hash: 83d4623
Edison-CBS
pushed a commit
to Edison-CBS/openpilot
that referenced
this pull request
Sep 15, 2024
) Revert "selfdrive/car: ban imports from external modules (commaai#32973)" This reverts commit c1e8ff2dbc47ccb07fb41a4e88bfb66af2669254. old-commit-hash: 35a4a77
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continue work from PR #32726, Added an
ignore_importssection for modules that will not be checked for now.