Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools/rerun: correct reset to defined default blueprint #32692

Merged
merged 2 commits into from
Jun 10, 2024
Merged

tools/rerun: correct reset to defined default blueprint #32692

merged 2 commits into from
Jun 10, 2024

Conversation

bongbui321
Copy link
Contributor

@bongbui321 bongbui321 commented Jun 10, 2024 •
edited
Loading

previously, if you want to reset our blueprint to the pre-defined one, it would reset to the one auto-generated one by Rerun.

Intended behaviour: when we press reset, it would go back to our defined default blueprint rather than the one from Rerun

Fix:
The default_blueprint arg should be defined in the connect() rather than in init()

@github-actions github-actions bot added the tools label Jun 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 10, 2024 •
edited
Loading

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@bongbui321 bongbui321 changed the title tools/rerun: enable resetting to the defined default blueprint rather than the auto-generated one by Rerun tools/rerun: correct reset to defined default blueprint Jun 10, 2024
@adeebshihadeh adeebshihadeh merged commit 1e3d62c into commaai:master Jun 10, 2024
17 checks passed
@bongbui321 bongbui321 deleted the reset_default_blueprint branch June 11, 2024 00:16
Edison-CBS pushed a commit to Edison-CBS/openpilot that referenced this pull request Sep 15, 2024
@bongbui321
tools/rerun: correct reset to defined default blueprint (commaai#32692)
c34f76b 
old-commit-hash: 1e3d62c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bongbui321 @adeebshihadeh