Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common/ratekeeper: change frame() return type from double to uint64_t #32679

Merged
merged 1 commit into from
Jun 10, 2024
Merged

common/ratekeeper: change frame() return type from double to uint64_t #32679

merged 1 commit into from
Jun 10, 2024

Conversation

deanlee
Copy link
Contributor

@deanlee deanlee commented Jun 10, 2024

This change ensures the return type matches the frame_ member variable

@github-actions GitHub Actions
Copy link
Contributor

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@adeebshihadeh adeebshihadeh merged commit a4f0f6c into commaai:master Jun 10, 2024
15 checks passed
@deanlee deanlee deleted the ratekeeper branch June 11, 2024 02:07
Edison-CBS pushed a commit to Edison-CBS/openpilot that referenced this pull request Sep 15, 2024
@deanlee
common/ratekeeper: change frame() return type from double to uint64_t (…
061deaa 
…commaai#32679)

old-commit-hash: a4f0f6c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deanlee @adeebshihadeh