Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency: remove pycurl package #30771

Merged
merged 28 commits into from
Dec 18, 2023
Merged

Conversation

royjr
Copy link
Contributor

@royjr royjr commented Dec 17, 2023

may fix #30763

comma@comma-33e0a0c6:/data/openpilot$ python tools/lib/tests/test_caching.py
....
----------------------------------------------------------------------
Ran 4 tests in 3.145s

OK

@royjr royjr marked this pull request as draft December 17, 2023 06:02
@royjr royjr marked this pull request as ready for review December 17, 2023 08:59
system/qcomgpsd/qcomgpsd.py Outdated Show resolved Hide resolved
system/qcomgpsd/qcomgpsd.py Outdated Show resolved Hide resolved
tools/lib/url_file.py Outdated Show resolved Hide resolved
tools/lib/url_file.py Show resolved Hide resolved
tools/lib/url_file.py Outdated Show resolved Hide resolved
tools/lib/url_file.py Outdated Show resolved Hide resolved
tools/lib/url_file.py Outdated Show resolved Hide resolved
tools/lib/url_file.py Show resolved Hide resolved
tools/lib/url_file.py Show resolved Hide resolved
@royjr
Copy link
Contributor Author

royjr commented Dec 17, 2023

fixed debug

ValueError: Format specifier missing precision

by setting precision value

get https://commadataci.blob.core.windows.net/openpilotci/0375fdf7b1ce594d/2019-06-13--08-32-25/3/qlog.bz2 {'Connection': 'keep-alive', 'Range': 'bytes=239824-239923'} 0.284 slow
get https://commadataci.blob.core.windows.net/openpilotci/0375fdf7b1ce594d/2019-06-13--08-32-25/3/qlog.bz2 {'Connection': 'keep-alive'} 0.548 slow

@adeebshihadeh adeebshihadeh merged commit 70624ff into commaai:master Dec 18, 2023
20 of 22 checks passed
@adeebshihadeh
Copy link
Contributor

Thanks, this was one of the worse dependencies for native macOS support.

I just bumped up this one to $500 if you wanna try it - #30706.

@royjr royjr deleted the replace-pycurl branch December 18, 2023 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[$100 bounty] Remove pycurl usage
2 participants