Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VW: Add more CRC data identifiers #1359

Closed
wants to merge 1 commit into from

Conversation

dalathegreat
Copy link

What

This PR adds more VAG magic bytes to the 8H2F Autosar lookup table.

Why

To make it easier for people reverse engineering Volkswagen CAN

How

During some VW MEB reverse engineering, I found these decoded on this excellent repository

@github-actions github-actions bot added the can related to CAN tools, aka opendbc/can/ label Oct 8, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to opendbc! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • include a route or your device' dongle ID if relevant

@jyoung8607 jyoung8607 changed the title Add more VAG magic bytes VW: Add more CRC data identifiers Oct 8, 2024
@jyoung8607
Copy link
Collaborator

Last time this came up, we decided it was okay to add messages we don't actively use in openpilot, but only if we have test coverage. That's going to require a DBC.

Do you have one you're working with? I have a little info, it seems very similar to MQBevo.

@jyoung8607 jyoung8607 marked this pull request as draft October 8, 2024 21:14
@dalathegreat
Copy link
Author

@jyoung8607 Unfortunately I have no DBC, I am going straight for an implementation to use MEB platform batteries in standalone mode. PR open here on the Battery-Emulator. Once we are completed, we can start owrking on a DBC for the MEB. So feel free to reject this PR (but having the info here will help others doing reverse engineering)

@jyoung8607
Copy link
Collaborator

If you can supply the sixteen necessary sample messages (one for each counter value) I can help you construct a DBC with placeholder entries, even if we don't know the meaning of many/most bits.

@dalathegreat
Copy link
Author

I can get back to this once we are completed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can related to CAN tools, aka opendbc/can/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants