Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toyota: clean up longitudinal message sending #1378

Closed
sshane opened this issue Oct 15, 2024 · 1 comment
Closed

Toyota: clean up longitudinal message sending #1378

sshane opened this issue Oct 15, 2024 · 1 comment

Comments

@sshane
Copy link
Contributor

sshane commented Oct 15, 2024

The code to come up with the longitudinal signals (accel, permit braking, etc) is running at 100 Hz, but we intend to send the ACC message at 33 Hz. This makes it slightly harder to reason about rate limiting, and should be combined similarly to other ports (GM is a good example). We also don't shouldn't send the ACC message at 100 Hz if canceling unless stock longitudinal, as that seems to break canceling when toggling the distance button (for joystick mode)

@sshane
Copy link
Contributor Author

sshane commented Nov 9, 2024

Done in #1390 and #1466

@sshane sshane closed this as completed Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant