CANPacker: fix incorrect counters assignment (#1047)

* fix counter * catch this issue in test case
commaai · Jun 6, 2024 · b0ca681 · b0ca681
1 parent 2ed4225
commit b0ca681
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/can/packer.cc b/can/packer.cc
@@ -60,9 +60,9 @@ std::vector<uint8_t> CANPacker::pack(uint32_t address, const std::vector<SignalP
     }
     set_value(ret, sig, ival);
 
-    counter_set = counter_set || (sigval.name == "COUNTER");
-    if (counter_set) {
+    if (sigval.name == "COUNTER") {
       counters[address] = sigval.value;
+      counter_set = true;
     }
   }
 

diff --git a/can/tests/test_packer_parser.py b/can/tests/test_packer_parser.py
@@ -60,6 +60,7 @@ def test_packer_counter(self):
       cnt = random.randint(0, 255)
       msg = packer.make_can_msg("CAN_FD_MESSAGE", 0, {
         "COUNTER": cnt,
+        "SIGNED": 0
       })
       dat = can_list_to_can_capnp([msg, ])
       parser.update_strings([dat])