Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal download API: Add proper validated directory input #4981

Merged
merged 16 commits into from
Sep 24, 2024
Merged

Internal download API: Add proper validated directory input #4981

merged 16 commits into from
Sep 24, 2024

Commits on Sep 19, 2024

  1. add internal /folder_paths route 

    returns a json maps of folder paths
    @mcmonkey4eva
    mcmonkey4eva committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    f1fd28d View commit details
    Browse the repository at this point in the history

  2. (minor) format download_models.py

    @mcmonkey4eva
    mcmonkey4eva committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    cbaffac View commit details
    Browse the repository at this point in the history

  3. initial folder path input on download api

    @mcmonkey4eva
    mcmonkey4eva committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    618f4d8 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'add-internal-folder-paths-route' into download-api-add-… 

    …directory-input
    @mcmonkey4eva
    mcmonkey4eva committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    f7eef1e View commit details
    Browse the repository at this point in the history

  5. actually, require folder_path and clean up some code

    @mcmonkey4eva
    mcmonkey4eva committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    80a9167 View commit details
    Browse the repository at this point in the history

  6. partial tests update

    @mcmonkey4eva
    mcmonkey4eva committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    68f8d8c View commit details
    Browse the repository at this point in the history

  7. fix & logging

    @mcmonkey4eva
    mcmonkey4eva committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    c539ee5 View commit details
    Browse the repository at this point in the history

  8. also download to a tmp file not the live file 

    to avoid compounding errors from network failure
    @mcmonkey4eva
    mcmonkey4eva committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    cfb5d6a View commit details
    Browse the repository at this point in the history

  9. update tests again

    @mcmonkey4eva
    mcmonkey4eva committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    3e8dbd5 View commit details
    Browse the repository at this point in the history

  10. test tweaks

    @mcmonkey4eva
    mcmonkey4eva committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    57a91a2 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2024

  1. Merge branch 'master' into download-api-add-directory-input

    @mcmonkey4eva
    mcmonkey4eva committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    db1814c View commit details
    Browse the repository at this point in the history

  2. workaround the first tests blocker

    @mcmonkey4eva
    mcmonkey4eva committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    3ac444c View commit details
    Browse the repository at this point in the history

  3. fix file handling in tests

    @mcmonkey4eva
    mcmonkey4eva committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    6fbceea View commit details
    Browse the repository at this point in the history

  4. rewrite test for create_model_path

    @mcmonkey4eva
    mcmonkey4eva committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    0df1e73 View commit details
    Browse the repository at this point in the history

  5. minor doc fix

    @mcmonkey4eva
    mcmonkey4eva committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    ae931da View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. avoid 'mock_directory' 

    use temp dir to avoid accidental fs pollution from tests
    @mcmonkey4eva
    mcmonkey4eva committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    89b3539 View commit details
    Browse the repository at this point in the history