Add docstring to token_weights() and related functions in sd1_clip #4640
+148
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh... there are indentation issues. |
Looks like I forgot to set my editor to use spaces instead of tabs, should be fixed now :) |
mcmonkey4eva
added
User Support
mcmonkey4eva
added
the
Good PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's my attempt at adding some documentation for the behavior seen in #4610. Hopefully the explanation I gave in the docstring makes sense :)
I got a little carried away and also added a docstring for escape_important() and unescape_important(); documenting those two functions isn't all that helpful to explaining how nesting works in token_weights(), but I'm figuring that there's no harm in adding a little extra documentation.