Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] Test guard #4012

Closed
wants to merge 3 commits into from
Closed

[DO NOT MERGE] Test guard #4012

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a37b79
Add front end change guard
huchenlei Jul 13, 2024
caebb15
test change
huchenlei Jul 13, 2024
c9cafff
Add permission
huchenlei Jul 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions .github/workflows/front-end-guard.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
# Guard any changes under web/ directory

on:
pull_request:
branches:
- main
- master
paths:
- "web/**"

jobs:
commentIfWebChanges:
runs-on: ubuntu-latest
if: ${{ !contains(github.event.pull_request.labels.*.name, 'Direct FrontEnd Change') }}
permissions:
pull-requests: "write"
steps:
- name: Post comment on PR and apply label
uses: actions/github-script@v6
with:
github-token: ${{secrets.GITHUB_TOKEN}}
script: |
const issue_number = context.issue.number;

// Add comment
const message = "No direct changes are allowed in the web/ directory."
"Please submit the change to https://github.com/Comfy-Org/ComfyUI_frontend";
github.rest.issues.createComment({
issue_number: issue_number,
owner: context.repo.owner,
repo: context.repo.repo,
body: message
});
// Apply label
github.rest.issues.addLabels({
issue_number: issue_number,
owner: context.repo.owner,
repo: context.repo.repo,
labels: ['Direct FrontEnd Change']
});
2 changes: 2 additions & 0 deletions web/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
await app.setup();
window.app = app;
window.graph = app.graph;

console.log("test change!");
</script>
</head>
<body class="litegraph">
Expand Down
Loading