Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Animated image output support #2008

Merged
merged 11 commits into from
Nov 21, 2023
Merged

Animated image output support #2008

merged 11 commits into from
Nov 21, 2023

Conversation

pythongosssss
Copy link
Contributor

@pythongosssss pythongosssss commented Nov 20, 2023 •
edited
Loading

  • Refactors the customtext DOM element handling into a new addDOMWidget function that can be used elsewhere
  • Changes images to be rendered as IMG elements supporting animation when any image is returned from a node with "ui": { "images": (gif, ...), "animated": (True, ... ) }
  • Adds setting to enable clipping of the selected node, meaning any DOM elements that would previously overlap the selected node will now be clipped. This only applies to the selected node as running the check on everything may cause some performance issues (i'm not sure how heavy the clip-path rendering is, so i've added the setting so people can disable it if required)

@pythongosssss pythongosssss marked this pull request as draft November 20, 2023 18:38
@pythongosssss pythongosssss changed the title Animated WebP image output support Animated image output support Nov 20, 2023
@pythongosssss pythongosssss marked this pull request as ready for review November 20, 2023 18:59
@pythongosssss pythongosssss marked this pull request as draft November 20, 2023 20:17
@pythongosssss pythongosssss marked this pull request as ready for review November 20, 2023 20:35
@comfyanonymous comfyanonymous merged commit 6ff06fa into comfyanonymous:master Nov 21, 2023
1 check passed
@pythongosssss pythongosssss deleted the dom-widgets branch December 17, 2023 17:47
HorusElohim pushed a commit to HorusElohim/PyfyUI that referenced this pull request Feb 17, 2024
@pythongosssss @HorusElohim
Animated image output support (comfyanonymous#2008)
64344b0 
* Refactor multiline widget into generic DOM widget

* wip webp preview

* webp support

* fix check

* fix sizing

* show image when zoomed out

* Swap webp checkto generic animated image flag

* remove duplicate

* Fix falsy check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comfyanonymous comfyanonymous Awaiting requested review from comfyanonymous comfyanonymous is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pythongosssss @comfyanonymous