Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MathBinary bug #830

Open
WeichenXu123 opened this issue Sep 23, 2022 · 2 comments
Open

Fix MathBinary bug #830

WeichenXu123 opened this issue Sep 23, 2022 · 2 comments
Labels
bug

Comments

@WeichenXu123
Copy link
Contributor

Fix MathBinary bug

See #824 (comment)
@WeichenXu123 WeichenXu123 mentioned this issue Sep 23, 2022
Merged
@austinzh
Copy link
Contributor

Hi @WeichenXu123 Would you mind elaborate with more details?
We are currently working on MathBinary, Maybe we can fix this in the sametime If we have more context.

@WeichenXu123
Copy link
Contributor Author

@austinzh
You can see this line in my PR:
https://github.com/combust/mleap/pull/824/files#r971927427

        # TODO: Deserialization on output_features has some issue. fix this.
        # assert_frame_equal(res_a, res_b)

If you enable this line assert_frame_equal(res_a, res_b), you will find the test failed, but it should pass.
So this is a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@austinzh @WeichenXu123