Add standard-rails and apply suggested updates #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albus522
reviewed
Jan 16, 2024
| User.find(changes["user_id"] || [user_id]).each do |user| | ||
| user.last_pour_at = user.pours.finished.maximum(:created_at) | ||
| user.save | ||
| if finished_at && (user_id_changed? || finished_at_changed?) |
There was a problem hiding this comment.
Huh, that's why that hasn't been working. This is in an after save, so *_changed? is always false
There was a problem hiding this comment.
Also, technically, if the user_id changed, it should be updating 2 users. There are a couple of errors I've spotted on my home install that I should push updates for.
albus522
reviewed
Jan 16, 2024
| @@ -45,7 +45,7 @@ def check_dead | |||
| def start_missing | |||
| return unless @running | |||
|
|
|||
| BeerTap.all.each do |tap| | |||
| BeerTap.all.each do |tap| # standard:disable Rails/FindEach | |||
There was a problem hiding this comment.
find_each is probably fine, but definitely overkill
There was a problem hiding this comment.
yeah, same thought.
albus522
approved these changes
Jan 16, 2024
albus522
reviewed
Jan 16, 2024
| @@ -7,7 +7,7 @@ def index | |||
| def destroy | |||
| keg = Keg.find(params[:keg_id]) | |||
| pour = keg.pours.find(params[:id]) | |||
| pour.destroy | |||
| pour.destroy! | |||
| redirect_to :back | |||
There was a problem hiding this comment.
This for example is wrong. It was replaced by redirect_back_or_to
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.