Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizations #110

Open
ale-rt opened this issue Nov 27, 2020 · 2 comments
Open

Optimizations #110

ale-rt opened this issue Nov 27, 2020 · 2 comments

Comments

@ale-rt
Copy link
Member

ale-rt commented Nov 27, 2020

I am reporting quickly what I found.
When I finished my assessment I will make this issue look better!

Replace

if request and rcachekey in list(request.keys()):
     return request[rcachekey]
return VALUE_NOT_CACHED

with something like:

return (request or {}).get(rcachekey, VALUE_NOT_CACHED)

or at list replace rcachekey in list(request.keys()) with rcachekey in request.

Also this does not work for subrequests: I see multiple connections for every tile I use and for the diazo compilation.
Caching the connection in memcached might be better.
BTW I do not know if I have the plugin improperly configured ;)

jensens added a commit that referenced this issue Feb 9, 2022
@jensens
Copy link
Member

jensens commented Feb 9, 2022

subrequests indeed. we should get the root-parent first in a non expensive way

jensens added a commit that referenced this issue Feb 9, 2022
@ale-rt
Copy link
Member Author

ale-rt commented Feb 10, 2022

Thanks @jensens for moving this forward

jensens added a commit that referenced this issue Jun 14, 2023
jensens added a commit that referenced this issue Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants