Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo #61

Open
flipmcf opened this issue Dec 6, 2021 · 2 comments
Open

Undo #61

flipmcf opened this issue Dec 6, 2021 · 2 comments

Comments

@flipmcf
Copy link
Contributor

flipmcf commented Dec 6, 2021

after I rename hundreds of thousands of objects - and then realize it was a bad idea - can I undo?

@gforcada
Copy link
Member

gforcada commented Dec 7, 2021

That should be a transaction undo, right? 🤔 if we are not breaking that into smaller transactions... that can be complicated... one could annotate a transaction (I think one can, right? I never done that myself) and then search for those specific transactions to undo them... If meanwhile someone edited an object it might not be possible to undo the transaction 😕 maybe a confirmation dialog that XXX amount of objects are going to be updated? might avoid that?

@flipmcf
Copy link
Contributor Author

flipmcf commented Dec 8, 2021

I'm having the same thoughts.

The confirmation dialog is #60

Right now, I am pretty sure, that each object is changed with it's own transaction - editing hundreds of objects creates hundreds of single transactions - I think.


The ZODB undo shows one transaction on '/prefs_keywords_view' but I haven't yet experimented with it.

So yeah, this is going to be tough. I like the annotation idea if we can't use an actual transaction, but that opens another can of worms when it comes to cleanup / packing. It's not responsible to leave that stuff hanging around forever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants