-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post comments support #74
Comments
thats a good question! so my original thought was to not use the wordpress comment system with the idea being if someone wanted to implement comments, they may be better off using a more interactive clientside experience like Disqus or something im certainly not opposed to it though and dont feel incredibly strongly about it. one consideration is if the comments were to be constantly up to date for an active site, the site would need to rebuild on each comment which would take a bit of time. another reason why a clientside dynamic experience might be better thoughts? would also like to hear what @doingandlearning thinks |
I think you're right, comments are definitely a thing to be more interactive/dynamic. Seems like a much better option to leave the user implement Disqus, Commento, etc Some other considerations/questions I was wondering also: |
yeah let's hear what Kevin says, he's more in tune with the WordPress community than i am that said, i want to explore the idea of plugins, but im not quite sure how the plugins would functionally work yet, as in, how would we "plug in" the functionality to the starter 🤔 |
Sorry for the delay in weighing in on this, there are a few competing approaches here.
I agree with @GuilleAngulo that having comment support would be good - I'm interested the Postlight don't seem to support comments out of the box (https://github.com/postlight/headless-wp-starter) - maybe this is an There is a bit of controversy around headless WP and JAMstack at the moment and comments (or difficulty of them in the JAMstack) is one of the hot points. |
i like the idea of including it as an example when we start building all that out and @GuilleAngulo if you'd like to contribute to that you're more than welcome to, i would just make you an author in the WordPress instance i use for this project. we're going to make it a "blog-like" experience to showcase leveraging WordPress for the documentation site, so the example walk-through could be a blog post |
Sure! Just to clarify: It would be a walk-through example (as a blog post) explaining how to add WP comment system support using graphql query/mutation, right? |
yeah so really it can be whatever you want! whether it's using the comment system or Disqus or something else my ambitious goal would be to start a collection of these little posts that can help people get up and running with different setups revolving WordPress. For instance, I would imagine one post, whether Kevin or I writes it, could be about adding WPGraphQL to WordPress through the admin no pressure :) just a nice way to provide some documentation, give an opportunity to write something, and use that as a way to test the project with its own content! |
Description
Should the site have support for post comments? Would be an interesting feature? I'm thinking as starting point it could be:
It implies to add the count of comments at getAllPosts query, and comments data and lib files (to manage its own queries and functions). What do you think?
Screenshots
The text was updated successfully, but these errors were encountered: