Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make secret with registry credentials configurable #58

Open
ksimon1 opened this issue Oct 2, 2024 · 3 comments
Open

Make secret with registry credentials configurable #58

ksimon1 opened this issue Oct 2, 2024 · 3 comments

Comments

@ksimon1
Copy link
Contributor

ksimon1 commented Oct 2, 2024

In cluster user can have multiple secrets for multiple registries. We should allow user to define which secret the task should use
/cc @codingben

@codingben
Copy link
Owner

@ksimon1 Isn't enough to change the name of the secret [1] and then re-deploy the kubevirt-disk-uploader pod?

[1] https://github.com/codingben/kubevirt-disk-uploader/blob/main/kubevirt-disk-uploader.yaml#L48

@ksimon1
Copy link
Contributor Author

ksimon1 commented Oct 2, 2024

nope, how would you solve two pipelineRuns running at the same time using the same pipeline, each one pushing to different registries with different secret?

@codingben
Copy link
Owner

@ksimon1 Do you mean to multi-registry option? Currently the tool accepts only one registry per execution.

Yes, I think that it would be nice feature to push to multiple registries per execution to populate them with the exported disk image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants