Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

update #2

wants to merge 2 commits into from

Conversation

islamshahil
Copy link

Take test image using camera

@islamshahil
update
3e43ec1 
Take test image using camera
@ionicc
Copy link
Member

ionicc commented Apr 14, 2019

Thanks for the contribution, But try to make these changes:
->The addition of taking a picture from the webcam is great but it shouldn't replace the original test.jpg
Instead make an argparse and ask the user if they want a picture from the webcam or a raw picture from a directory.
->The path to the shape predictor file should be relative as otherwise it will fail in other systems.

Have fun 😄

ionicc
ionicc requested changes Apr 14, 2019
View reviewed changes
Copy link
Member

@ionicc ionicc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned above

@islamshahil
Update
dbada3e 
Using tkinter, created a message box which allows you to choose between web cam and default picture as your test picture.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ionicc ionicc ionicc requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@islamshahil @ionicc