From 3861e5d60d1bebdc81ae2a8084d5ec10fbdf829b Mon Sep 17 00:00:00 2001 From: Dorian Lesbre Date: Fri, 12 Jul 2024 21:28:08 +0200 Subject: [PATCH] github issue --- README.md | 2 +- src/index.mld | 3 ++- src/key_value.mli | 3 ++- src/signatures.ml | 3 ++- 4 files changed, 7 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index bc0d89c..e961bcf 100644 --- a/README.md +++ b/README.md @@ -322,7 +322,7 @@ type (_, 'b) snd = Snd of 'b [@@unboxed] It should not incur any extra performance cost as it is unboxed, but can appear when manipulating non-generic maps. -For more details about this issue, see [the OCaml discourse discussion](https://discuss.ocaml.org/t/weird-behaviors-with-first-order-polymorphism/13783). +For more details about this issue, see [the OCaml discourse discussion](https://discuss.ocaml.org/t/weird-behaviors-with-first-order-polymorphism/13783) or [the github issue](https://github.com/ocaml/ocaml/issues/13292). ## Comparison to other OCaml libraries diff --git a/src/index.mld b/src/index.mld index 90219c9..2f103d3 100644 --- a/src/index.mld +++ b/src/index.mld @@ -419,7 +419,8 @@ type (_, 'b) snd = Snd of 'b [@@unboxed] It should not incur any extra performance cost as it is unboxed, but can appear when manipulating non-generic maps. -For more details about this issue, see {{: https://discuss.ocaml.org/t/weird-behaviors-with-first-order-polymorphism/13783}the OCaml discourse discussion}. +For more details about this issue, see {{: https://discuss.ocaml.org/t/weird-behaviors-with-first-order-polymorphism/13783}the OCaml discourse discussion} +or {{: https://github.com/ocaml/ocaml/issues/13292}the github issue}. {1 Comparison to other OCaml libraries} diff --git a/src/key_value.mli b/src/key_value.mli index 57185f5..e90188a 100644 --- a/src/key_value.mli +++ b/src/key_value.mli @@ -34,7 +34,8 @@ module WrappedHomogeneousValue : HETEROGENEOUS_VALUE with type ('a,'map) t = ('a (** Same as {!HomogeneousValue}, but uses a wrapper (unboxed) type instead of direct equality. This avoids a problem in the typechecker with overly eager simplification of aliases. More info on - {{: https://discuss.ocaml.org/t/weird-behaviors-with-first-order-polymorphism/13783} the OCaml discourse post}. *) + {{: https://discuss.ocaml.org/t/weird-behaviors-with-first-order-polymorphism/13783} the OCaml discourse post} + and {{: https://github.com/ocaml/ocaml/issues/13292}the github issue}. *) module HashedValue : HASHED_VALUE with type 'a t = 'a (** Generic implementation of {!HASHED_VALUE}. diff --git a/src/signatures.ml b/src/signatures.ml index dc9e2d3..0fded08 100644 --- a/src/signatures.ml +++ b/src/signatures.ml @@ -797,7 +797,8 @@ end Since the type is unboxed, it doesn't introduce any performance overhead. This is due to a bug in the typechecker, more info on - {{: https://discuss.ocaml.org/t/weird-behaviors-with-first-order-polymorphism/13783} the OCaml discourse post}. *) + {{: https://discuss.ocaml.org/t/weird-behaviors-with-first-order-polymorphism/13783} the OCaml discourse post} + and {{: https://github.com/ocaml/ocaml/issues/13292}the github issue}. *) type (_, 'b) snd = Snd of 'b [@@unboxed]