Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand the option for video crop also to pagetype "video player" #1203

Open
rufposten opened this issue Aug 19, 2019 · 3 comments
Open

Expand the option for video crop also to pagetype "video player" #1203

rufposten opened this issue Aug 19, 2019 · 3 comments

Comments

@rufposten
Copy link

Currently, the field of view (viewport) settings and hence the ability to view 16:9 media on a smartphone trimmed in 9:16 is currently only available for the background pagetype. Here even the background videos get trimmed so they fill the whole screen.

Would be great if also the pagetype "video player" would have an option to change the aspect ratio of the videos on a smartphone accordingly. Should be optional, as not all videos are suitable for trimming.

theres

@rufposten rufposten changed the title Expand the option for vertical video crop also to pagetype "video player" Expand the option for video crop also to pagetype "video player" Aug 19, 2019
@tf
Copy link
Member

tf commented Aug 23, 2019

I agree this would be nice to have. As a prerequisite one would need to change the way the video page works on iOS. There we still rely on Safari's built in video player which opens in a modal instead of using our own player controls like on Android (see screenshot above). Once that change is done, adding the option should not be to difficult since the video page uses the same video component that is also used for background videos.

We currently have no plans to work on this change. If you should be interested to dive into the technical details, I'd be happy to give some pointers.

@rufposten
Copy link
Author

Nice to hear that it is easy and appreciated! I already looked into the code and discovered that it's impossible to do in script-kiddie-mode without understanding ruby. But probably someone else?

@rufposten
Copy link
Author

Now after introducing vertical background video as a second upload option and portrait inline video in Next I wonder if this issue regarding viewport and aspect for Pageflow Classic would be easier to solve?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants