Use React Query #19
Merged
Use React Query #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LamboCreeper
requested review from
Jason2605,
theboxmage and
saramaebee
as code owners
Jason2605
reviewed
May 9, 2024
| }, [user, request]); | ||
| const { data: gitRepositories } = useQuery({ | ||
| queryKey: ["github", "repositories", gitUser?.login.toLowerCase()], | ||
| queryFn: async () => githubService.getUsersRepositories(gitUser!.login), |
There was a problem hiding this comment.
Do we want to await here?
Or not mark it as async and just return the call to getUserRepository
There was a problem hiding this comment.
No need since the Promise is being directly returned. I don't think there is any advantage to having the Promise resolved within the scope of queryFn.
Discussed on Discord - will change.
Jason2605
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we will be doing a lot of API calls to GitHub and Firestore in this project, I believe it is beneficial to use a caching system. I have gone for React Query as it seems like it should do everything we need and more.
I've set it up and replaced all instances of
useGitHub()with a React Query implementation. This is my first time using this library, so hopefully we're doing it right!