Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicate va_end call #617

Open
wants to merge 1 commit into
base: 3.x
Choose a base branch
from

Conversation

zmiklank
Copy link

From man va_end:

va_end()
  Each  invocation  of  va_start()  must  be  matched  by a corresponding invocation of
  va_end() in the same function.  After the call va_end(ap) the variable  ap  is  unde‐
  fined.   Multiple  traversals  of the list, each bracketed by va_start() and va_end()
  are possible.  va_end() may be a macro or a function.

In the _gu_db_doprnt_ function the va_end is called on the already undefined args variable, which can cause undefined behavior. This PR proposes to remove one va_end(args) call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant