Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homework CI check Issue - lambdas #63

Open
mBialczak opened this issue Dec 13, 2022 · 2 comments
Open

Homework CI check Issue - lambdas #63

mBialczak opened this issue Dec 13, 2022 · 2 comments

Comments

@mBialczak
Copy link

I believe that there is a problem in one of the CI tasks checking homework for lambdas.
It is named "template-check".
I cannot pass check defined in ./template_check.sh
I suppose that the pattern pattern="template\s*<.*(typename\s*\.\.\.\s*\w*).*>\s*void\s+schedule\(.*\)\s*{"
used might not be perfect.
In my case it doesn't treat below code as valid template function:
template <typename Action, typename... Args> void schedule(Action func, std::chrono::seconds time, Args... args) { std::this_thread::sleep_for(time); std::invoke(func, std::forward<Args>(args)...); }

But it builds and passes all other tests.

@ziobron
Copy link
Contributor

ziobron commented Dec 13, 2022

🏅 2 XP granted for @mBialczak
Thanks for raising this Issue to help to make the course better!

@ziobron
Copy link
Contributor

ziobron commented Dec 20, 2022

I've checked the regexp and it works with your input. The problem must be somewhere else. I'll take a closer look after the New Year. Thank you for raising this issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants