KUBESAW-43: Replace the special ToolchainClusterCondition with the standard toolchain Condition #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…andard toolchain Condition Signed-off-by: Feny Mehta <[email protected]>
fbm3307
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19,
sbryzak and
mfrancisc
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #391 +/- ##
==========================================
- Coverage 77.87% 77.79% -0.08%
==========================================
Files 47 47
Lines 1984 1977 -7
==========================================
- Hits 1545 1538 -7
Misses 378 378
Partials 61 61
|
This was referenced Apr 25, 2024
fbm3307
force-pushed
the
ks43replacecondition
branch
2 times, most recently
from
55e472b
to
bac35a1
Compare
Signed-off-by: Feny Mehta <[email protected]>
Signed-off-by: Feny Mehta <[email protected]>
MatousJobanek
approved these changes
May 16, 2024
Signed-off-by: Feny Mehta <[email protected]>
mfrancisc
approved these changes
May 27, 2024
Signed-off-by: Feny Mehta <[email protected]>
Signed-off-by: Feny Mehta <[email protected]>
Signed-off-by: Feny Mehta <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to replace the special ToolchainClusterCondition with the standard toolchain Condition.
This is Related to Change in
Only change is updating the dependency of API and toolchain-common