From e6bab9311412c9ce76c0943933feeca6437d0181 Mon Sep 17 00:00:00 2001
From: Francesco Ilario <filario@redhat.com>
Date: Wed, 14 Feb 2024 18:23:40 +0100
Subject: [PATCH] Optimize binary (#403)

* Optimize binary

Removes DWARF and symbol tables from the binary. From [https://pkg.go.dev/cmd/link](https://pkg.go.dev/cmd/link):
- `-s`: Omit the symbol table and debug information
- `-w`: Omit the DWARF symbol table.

Also trims the path in panics so they will start from project's local
folder. From [https://pkg.go.dev/cmd/go](https://pkg.go.dev/cmd/go):
- `trimpath`: remove all file system paths from the resulting executable. Instead of absolute file system paths, the recorded file names will begin either a module path@version (when using modules), or a plain import path (when using the standard library, or GOPATH).

Signed-off-by: Francesco Ilario <filario@redhat.com>

* Add DWARF and symbol table in build-dev

Signed-off-by: Francesco Ilario <filario@redhat.com>

---------

Signed-off-by: Francesco Ilario <filario@redhat.com>
---
 make/build.mk | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/make/build.mk b/make/build.mk
index 35ff5ff6..f9350ed3 100644
--- a/make/build.mk
+++ b/make/build.mk
@@ -3,7 +3,7 @@ GO_PACKAGE_ORG_NAME ?= codeready-toolchain
 GO_PACKAGE_REPO_NAME ?= $(shell basename $$PWD)
 GO_PACKAGE_PATH ?= github.com/${GO_PACKAGE_ORG_NAME}/${GO_PACKAGE_REPO_NAME}
 
-export LDFLAGS=-ldflags "-X ${GO_PACKAGE_PATH}/pkg/configuration.Commit=${GIT_COMMIT_ID} -X ${GO_PACKAGE_PATH}/pkg/configuration.BuildTime=${BUILD_TIME}"
+export LDFLAGS=-X ${GO_PACKAGE_PATH}/pkg/configuration.Commit=${GIT_COMMIT_ID} -X ${GO_PACKAGE_PATH}/pkg/configuration.BuildTime=${BUILD_TIME}
 goarch ?= $(shell go env GOARCH)
 
 .PHONY: build build-prod build-dev
@@ -16,7 +16,7 @@ build: build-prod
 ## builds development binary
 build-dev:
 	$(Q)CGO_ENABLED=0 GOARCH=${goarch} GOOS=linux \
-		go build ${V_FLAG} ${LDFLAGS} \
+		go build ${V_FLAG} -ldflags="${LDFLAGS}" \
 		-tags dev \
 		-o $(OUT_DIR)/bin/registration-service \
 		cmd/main.go
@@ -25,7 +25,7 @@ build-dev:
 ## builds production binary
 build-prod: check-template-changes
 	$(Q)CGO_ENABLED=0 GOARCH=${goarch} GOOS=linux \
-		go build ${V_FLAG} ${LDFLAGS} \
+		go build ${V_FLAG} -ldflags="${LDFLAGS} -s -w" -trimpath \
 		-o $(OUT_DIR)/bin/registration-service \
 		cmd/main.go