Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerated from API - made UserSignup.Spec.IdentityClaims required #973

Merged
merged 28 commits into from
Feb 27, 2024

Conversation

sbryzak
Copy link
Contributor

@sbryzak sbryzak commented Feb 26, 2024

Copy link
Contributor

@rajivnathan rajivnathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the CRD yaml it looks like only these are required.

required:
- email
- preferredUsername
- sub

probably because the others are marked as optional https://github.com/codeready-toolchain/api/blob/1e69b9614bd81720b4de6d405f5438c3331f4182/api/v1alpha1/usersignup_types.go#L191-L201

I guess you need to remove the +optional from the individual fields within identityClaims to make them all required.

deploy/registration-service/registration-service.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@alexeykazakov alexeykazakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this PR is based on some outdated commit.

Copy link

openshift-ci bot commented Feb 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, mfrancisc, rajivnathan, ranakan19, sbryzak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alexeykazakov,sbryzak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

sonarcloud bot commented Feb 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
14.4% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Merging #973 (625ca36) into master (b033b2c) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #973      +/-   ##
==========================================
+ Coverage   83.62%   83.64%   +0.01%     
==========================================
  Files          55       55              
  Lines        6243     6243              
==========================================
+ Hits         5221     5222       +1     
+ Misses        837      836       -1     
  Partials      185      185              

see 1 file with indirect coverage changes

@sbryzak sbryzak merged commit c4bf618 into codeready-toolchain:master Feb 27, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants