Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DRAFT] Allow for disable inheritace when creating spaces #923

Closed
wants to merge 2 commits into from
Closed

[DRAFT] Allow for disable inheritace when creating spaces #923

wants to merge 2 commits into from

Conversation

mmulholla
Copy link
Contributor

@mmulholla mmulholla commented Nov 7, 2023 •
edited
Loading

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 7, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mmulholla
Once this PR has been reviewed and has the lgtm label, please assign matousjobanek for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mmulholla mmulholla mentioned this pull request Nov 7, 2023
Merged
@mmulholla mmulholla force-pushed the add_disableinheritance_for_spacebindings branch from 49854c8 to 50c4bde Compare November 7, 2023 22:02
@mmulholla mmulholla force-pushed the add_disableinheritance_for_spacebindings branch from 50c4bde to 902693d Compare November 8, 2023 15:27
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 13, 2023

@mmulholla: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e f392d92 link true /test e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mmulholla mmulholla closed this Nov 13, 2023
@mmulholla
Copy link
Contributor Author

Not ready yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatousJobanek MatousJobanek Awaiting requested review from MatousJobanek MatousJobanek is a code owner

@xcoulon xcoulon Awaiting requested review from xcoulon xcoulon is a code owner

@alexeykazakov alexeykazakov Awaiting requested review from alexeykazakov alexeykazakov is a code owner

@rajivnathan rajivnathan Awaiting requested review from rajivnathan rajivnathan is a code owner

@ranakan19 ranakan19 Awaiting requested review from ranakan19 ranakan19 is a code owner

@sbryzak sbryzak Awaiting requested review from sbryzak

@mfrancisc mfrancisc Awaiting requested review from mfrancisc mfrancisc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmulholla @alexeykazakov