Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add spacebindingrequest type #840

Merged

Conversation

mfrancisc
Copy link
Contributor

@mfrancisc mfrancisc commented Aug 2, 2023

This PR add a new API type SpaceBindingRequest, which will allow admin users to manage permissions on their own Space, and grant access to other users.

Jira: https://issues.redhat.com/browse/ASC-394

Related PRs:

Copy link
Contributor

@MatousJobanek MatousJobanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@MatousJobanek MatousJobanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving - just don't forget about the kustomization.yaml file

@openshift-ci
Copy link

openshift-ci bot commented Aug 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MatousJobanek, mfrancisc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 4, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mfrancisc
Copy link
Contributor Author

you should also update the kustomization yaml file https://github.com/codeready-toolchain/host-operator/blob/bbd64177f2582d2bc32f64db1efb6e912a49ebc5/config/crd/kustomization.yaml

Done 45441e4

Thanks, I always forget about that 🤦‍♂️ . Maybe we could add it to the api PR template.

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #840 (45441e4) into master (004f85a) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #840   +/-   ##
=======================================
  Coverage   83.05%   83.05%           
=======================================
  Files          50       50           
  Lines        5482     5482           
=======================================
  Hits         4553     4553           
  Misses        756      756           
  Partials      173      173           

@mfrancisc mfrancisc merged commit 976245a into codeready-toolchain:master Aug 7, 2023
11 checks passed
@mfrancisc mfrancisc deleted the spacebindingrequest-host branch August 7, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants