-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add spacebindingrequest type #840
feat: add spacebindingrequest type #840
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should also update the kustomization yaml file https://github.com/codeready-toolchain/host-operator/blob/bbd64177f2582d2bc32f64db1efb6e912a49ebc5/config/crd/kustomization.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving - just don't forget about the kustomization.yaml file
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MatousJobanek, mfrancisc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Kudos, SonarCloud Quality Gate passed! |
Done 45441e4 Thanks, I always forget about that 🤦♂️ . Maybe we could add it to the api PR template. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #840 +/- ##
=======================================
Coverage 83.05% 83.05%
=======================================
Files 50 50
Lines 5482 5482
=======================================
Hits 4553 4553
Misses 756 756
Partials 173 173 |
This PR add a new API type SpaceBindingRequest, which will allow admin users to manage permissions on their own Space, and grant access to other users.
Jira: https://issues.redhat.com/browse/ASC-394
Related PRs: