Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the definition of the toolchain-cluster label to the API so that it can be reused freely throughout the codebase. #423

Merged
merged 2 commits into from
May 14, 2024

Conversation

metlos
Copy link
Contributor

@metlos metlos commented May 9, 2024

Description

A trivial PR to add the definition of the new label required for the implementation of https://issues.redhat.com/browse/KUBESAW-16.

Related PRs:

Checks

  1. Did you run make generate target? yes

  2. Did make generate change anything in other projects (host-operator, member-operator)? no

  3. In case of new CRD, did you the following? no, not a new CRD

  4. In case other projects are changed, please provides PR links.

it can be reused freely throughout the codebase.
@metlos metlos changed the title Add the definition of the toolchain-cluster label to the API so thatit can be reused freely throughout the codebase. Add the definition of the toolchain-cluster label to the API so that it can be reused freely throughout the codebase. May 9, 2024
Copy link

sonarcloud bot commented May 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@mfrancisc mfrancisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I have one minor comment.

api/v1alpha1/toolchaincluster_types.go Show resolved Hide resolved
@metlos metlos merged commit 3b52373 into codeready-toolchain:master May 14, 2024
3 checks passed
@metlos metlos deleted the label-token-secrets branch May 14, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants