Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump kube-openapi version #421

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

filariow
Copy link
Contributor

Description

Update kube-openapi version and removes Fake GOPATH implementation

Checks

  1. Did you run make generate target? yes

  2. Did make generate change anything in other projects (host-operator, member-operator)? no

  3. In case of new CRD, did you the following? NA

  4. In case other projects are changed, please provides PR links. NA

Signed-off-by: Francesco Ilario <[email protected]>
Remove the no more needed fake GOPATH implementation

Signed-off-by: Francesco Ilario <[email protected]>
Signed-off-by: Francesco Ilario <[email protected]>
Copy link
Contributor

@mfrancisc mfrancisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the openapi tool 🙏
I've tested and it works fine for me.

My folder structure is pretty standard so let's wait for others to test it as well before merging.

Copy link
Contributor

@rajivnathan rajivnathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, worked well for me too

Copy link
Contributor

@fbm3307 fbm3307 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked for me

@@ -10,48 +10,48 @@ require (
k8s.io/apimachinery v0.25.0
k8s.io/code-generator v0.25.0
k8s.io/gengo v0.0.0-20211129171323-c02415ce4185
k8s.io/kube-openapi v0.0.0-20220803162953-67bda5d908f1
k8s.io/kube-openapi v0.0.0-20240430033511-f0e62f92d13f
Copy link
Contributor

@fbm3307 fbm3307 May 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a Thought , Do we need to discuss/resolve the update to kube-openapi version as i see PR https://github.com/codeready-toolchain/api/pull/409/files from @ranakan19 updating it to some different version , and here it updates to some latest version? wont that be conflicting or may be just duplication of work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! As kube-openapi is a controller-runtime indirect dependency, maybe it's worth to merge the other PR first and then just remove the FAKE GOPATH logic with this one.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fbm3307! I was thinking the same, but I wonder why there are no errors with the kube-openapi version you are upgrading to (which is the latest version) with the older controller-runtime version. Looking into this further.
As for merging the PR - I cannot merge the other PR untill all the other PRs across all repos are ready - so it may take another sprint or two to get to that stage. Would it be okay to wait?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah i see, the version you are updating to is the latest one from controller-runtime, not from the version of the controller-runtime we are currently on or would like to update it. It also has a higher version golang version. Since there is no error in upgrading to the latest version, because it is an indirect dependency, you could update the kube-openapi to this version if you need it for something. If not, I'd rather keep them updated in sync with the rest of the dependencies.
The version of kube-openapi for controller-runtime v0.15 is https://github.com/kubernetes-sigs/controller-runtime/blob/release-0.15/go.mod#L71

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, we should definitely keep them updated in sync. Unfortunately, we'll not being able to remove FAKE GOPATH implementation until -if I'm not mistaken- [email protected].

Copy link

sonarcloud bot commented May 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@fbm3307
Copy link
Contributor

fbm3307 commented Jul 11, 2024

@filariow probably we should put the PR to draft and pick up later or close this ( as per the above discussion)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants