Adding domains field to auto-approval config #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dperaza4dustbit
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19,
sbryzak and
mfrancisc
as code owners
dperaza4dustbit
force-pushed
the
auto_aproval_api
branch
from
048a724
to
0edfc1b
Compare
Implements: ASC-444 Signed-off-by: David Peraza <[email protected]>
Adding more descriptions to how domains will work with enabled. Signed-off-by: David Peraza <[email protected]>
dperaza4dustbit
force-pushed
the
auto_aproval_api
branch
from
0edfc1b
to
1c3b260
Compare
alexeykazakov
approved these changes
Apr 24, 2024
We want to start moving into a more inviting code base. Signed-off-by: David Peraza <[email protected]>
|
MatousJobanek
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements: ASC-444
Description
Adding a domain list to the auto-approval section in toolchain config resource. List will be used to allow
auto-approval for emails under specific domains.
Checks
Did you run
make generatetarget? yesDid
make generatechange anything in other projects (host-operator, member-operator)? yesIn case of new CRD, did you the following? NA
resources/setup/roles/host.yamlin the sandbox-sre repositoryPROJECTfile: https://github.com/codeready-toolchain/host-operator/blob/master/PROJECTCSVfile: https://github.com/codeready-toolchain/host-operator/blob/master/config/manifests/bases/host-operator.clusterserviceversion.yamlIn case other projects are changed, please provides PR links.