-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KSPACE-46: Deprecations #407
KSPACE-46: Deprecations #407
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
I like the Deprecated comments to the fields!
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Description
This just adds a few deprecations on fields of
ToolchainConfig
that are being replaced with functionality inSpaceProvisionerConfig
.Checks
Did you run
make generate
target? yesDid
make generate
change anything in other projects (host-operator, member-operator)? yes - changes to the field descriptions in the ToolchainConfig CRD.In case of new CRD, did you the following? N/A
In case other projects are changed, please provides PR links.