Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go install instead of get-tool.mk #406

Merged
merged 1 commit into from
Mar 14, 2024
Merged

go install instead of get-tool.mk #406

merged 1 commit into from
Mar 14, 2024

Conversation

MatousJobanek
Copy link
Contributor

Description

drop get-tool.mk and install the binaries via go install

Checks

  1. Did you run make generate target? yes/no

Yes

  1. Did make generate change anything in other projects (host-operator, member-operator)? yes/no

No

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@MatousJobanek MatousJobanek merged commit 3370931 into codeready-toolchain:master Mar 14, 2024
3 checks passed
mfrancisc
mfrancisc reviewed Mar 14, 2024
View reviewed changes
Copy link
Contributor

@mfrancisc mfrancisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfrancisc mfrancisc mfrancisc left review comments

@metlos metlos metlos approved these changes

@xcoulon xcoulon xcoulon approved these changes

@alexeykazakov alexeykazakov Awaiting requested review from alexeykazakov alexeykazakov is a code owner

@rajivnathan rajivnathan Awaiting requested review from rajivnathan rajivnathan is a code owner

@ranakan19 ranakan19 Awaiting requested review from ranakan19 ranakan19 is a code owner

@sbryzak sbryzak Awaiting requested review from sbryzak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MatousJobanek @metlos @xcoulon @mfrancisc