add disableInheritance for Spaces and SpaceRequests #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmulholla
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19,
sbryzak and
mfrancisc
as code owners
alexeykazakov
approved these changes
Nov 7, 2023
alexeykazakov
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
The PR looks good but please create separate PR for the host operator repo just to update the CRD.
This is how we usually introduce API changes:
- Change the API and generate the CRDs in the corresponding operator repos locally.
- Create an API PR and PRs for the corresponding operators repos with the updated CRDs.
- Get all of those PRs merged.
- Now you can create PRs which actually use the new API.
See an example of the first step here: Create webhook secret #385
|
PR codeready-toolchain/host-operator#927 created with just results from make generate. |
|
also one for member-operator: codeready-toolchain/member-operator#500 |
rajivnathan
approved these changes
Nov 8, 2023
mfrancisc
reviewed
Nov 9, 2023
mmulholla
force-pushed
the
addDisableInheritanceForSpaces
branch
2 times, most recently
from
440bb36
to
ea1ae26
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
I have added the file. Thx for the heads-up. |
alexeykazakov
approved these changes
Nov 9, 2023
Sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add disableInheritance flag to Space and SpaceRequest
see: https://issues.redhat.com/browse/ASC-428
Checks
Did you run
make generatetarget? yes/noDid
make generatechange anything in other projects (host-operator, member-operator)? yesIn case of new CRD, did you the following? no
resources/setup/roles/host.yamlin the sandbox-sre repositoryPROJECTfile: https://github.com/codeready-toolchain/host-operator/blob/master/PROJECTCSVfile: https://github.com/codeready-toolchain/host-operator/blob/master/config/manifests/bases/host-operator.clusterserviceversion.yamlIn case other projects are changed, please provides PR links.