Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestions for calculate_best_node #965

Open
shewenkan opened this issue Mar 2, 2023 · 1 comment
Open

suggestions for calculate_best_node #965

shewenkan opened this issue Mar 2, 2023 · 1 comment

Comments

@shewenkan
Copy link

the score of the grandpa node should not be discounted if it has son text_node with better score,for example: https://indianexpress.com/article/opinion/columns/c-raja-mohan-writes-cooperation-amid-conflict-is-indias-burden-for-g20-8472106/
the correct top_node is the div id="pcl-full-content" not div class="ev-meter-content"

@Dustin-MOP
Copy link

I agree 100 %. I am facing similar issues on multiple pages like this:
https://care-vita.de/2021/11/15/pflegefachkraft-in-werder/

Here, only the portion between "Deine Aufgaben" and the list above "Dein Profil" is considered as the "text" of that page. However, obviously that's not the case.
Maybe consider incorporating the search for h1, h2, etc. and rather taking the "outer wrapper node" (one that holds multiple "good" nodes/wrapper nodes)

I am not very experienced with Github otherwise I'd prepare a code recommendation...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@shewenkan @Dustin-MOP and others