Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve "Migration File Names" #9179

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Sep 8, 2024

Description
See #9177

  • improve the description for "Migration File Names"

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • [] Conforms to style guide

@kenjis kenjis added the documentation Pull requests for documentation only label Sep 8, 2024
The descriptive name (**AddBlogTable**) for the migration is a classname in PHP.
So you must name a valid classname.

The year, month, date, and time in a prefix can be separated from each other by
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The year, month, date, and time in a prefix can be separated from each other by
The year, month, day and time in a prefix can be separated from each other by

Why date?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@kenjis kenjis merged commit 647f4e7 into codeigniter4:develop Sep 9, 2024
4 checks passed
@kenjis kenjis deleted the improve-migration-file-names branch September 9, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests for documentation only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants