Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [OCI8] Easy Connect string validation #9006

Merged
merged 2 commits into from
Jun 30, 2024
Merged

fix: [OCI8] Easy Connect string validation #9006

merged 2 commits into from
Jun 30, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jun 27, 2024 •
edited
Loading

Description
Fixes #9005
Follow-up #8986

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer labels Jun 27, 2024
@kenjis kenjis force-pushed the fix-oci8-easy-connect-string-validation branch from 99de97f to f4f178d Compare June 27, 2024 00:53
@kenjis kenjis mentioned this pull request Jun 27, 2024
Closed
@kenjis kenjis force-pushed the fix-oci8-easy-connect-string-validation branch from f4f178d to 98365a7 Compare June 27, 2024 01:20
@kenjis kenjis force-pushed the fix-oci8-easy-connect-string-validation branch from 98365a7 to 6c61938 Compare June 27, 2024 01:26
@kenjis kenjis merged commit 1638990 into codeigniter4:develop Jun 30, 2024
42 checks passed
@kenjis kenjis deleted the fix-oci8-easy-connect-string-validation branch June 30, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datamweb datamweb datamweb approved these changes

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug(OCI8): $validDSNs regex for Oracle service names should support periods
3 participants
@kenjis @michalsn @datamweb